-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play button is not cleaned up on stop #1431
Labels
bug
This issue describes undesirable, incorrect, or unexpected behavior
Hacktoberfest
Issues marked for the community Hacktoberfest event https://hacktoberfest.digitalocean.com/
Comments
kamranayub
added
the
bug
This issue describes undesirable, incorrect, or unexpected behavior
label
Feb 26, 2020
5 tasks
eonarheim
added a commit
that referenced
this issue
May 21, 2020
This is still an issue, if you don't click the play button. I think engine needs to call |
kamranayub
added
the
Hacktoberfest
Issues marked for the community Hacktoberfest event https://hacktoberfest.digitalocean.com/
label
Sep 11, 2021
Workaround: function cleanUpPlayButtons() {
const playButtons = document.querySelectorAll("#excalibur-play-root");
playButtons.forEach((playButton) => {
if (playButton.parentNode) {
playButton.parentNode.removeChild(playButton);
}
});
} |
catrielmuller
added a commit
to catrielmuller/Excalibur
that referenced
this issue
Oct 23, 2021
…on the screen on some situations [excaliburjs#1431]
catrielmuller
added a commit
to catrielmuller/Excalibur
that referenced
this issue
Oct 23, 2021
…on the screen on some situations [excaliburjs#1431]
eonarheim
pushed a commit
that referenced
this issue
Oct 25, 2021
Co-authored-by: Erik Onarheim <erik.onarheim@gmail.com> Closes #1431 ## Changes: - `withEngine` utils support an aditional options parameter to override the Engine default options. - Story to show a play / pause implementation. - Dispatch the `hidePlayButton` on the Button Event to prevent that keep on the screen on some situations [#1431].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue describes undesirable, incorrect, or unexpected behavior
Hacktoberfest
Issues marked for the community Hacktoberfest event https://hacktoberfest.digitalocean.com/
Steps to Reproduce
Expected Result
Play button should disappear/be cleaned up
Actual Result
Play button sticks around
Environment
Current Workaround
Target HTML element manually and delete from DOM
The text was updated successfully, but these errors were encountered: