fix: [#1431] Dispatch the hidePlayButton on the Button Event to prevent that keep on the screen on some situations [#1431] #2066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kamranayub , I'm tried to reproduce the issue [#1431] that was resolved on the commit ( c5d710a )
So I created a Story to test this on different situations, I notices that if you use something like this
to implement a play/pause functionality, the showPlayButton show the button, however you need hide manually after the user click them again, to prevent that I recomend move that logic inside of the ShowPlayButton click event definition.
Also I added a Options property to the
withEngine
util to override the default engine options used by the all Stories.===:clipboard: PR Checklist :clipboard:===
==================
Closes #1431
Changes:
withEngine
utils support an aditional options parameter to override the Engine default options.hidePlayButton
on the Button Event to prevent that keep on the screen on some situations [Play button is not cleaned up on stop #1431].