Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excalibur gets confused when sound url contains a querystring #2599

Closed
eonarheim opened this issue Mar 10, 2023 · 0 comments · Fixed by #2600
Closed

Excalibur gets confused when sound url contains a querystring #2599

eonarheim opened this issue Mar 10, 2023 · 0 comments · Fixed by #2600

Comments

@eonarheim
Copy link
Member

eonarheim commented Mar 10, 2023 •
edited
Loading

Steps to Reproduce

In Parcel

For example coin.f74d9d70.mp3?1678266496281 will result in :

[Warn] : This browser does not support any of the audio files specified: http://localhost:1234/coin.f74d9d70.mp3?1678266496281

Expected Result

No warning logged

Actual Result

This should not log a warning in chrome, this is supported.

Environment

  • browsers and versions: Latest Chrome
  • operating system: Windows
  • Excalibur versions: latest main
  • (anything else that may be relevant)

Current Workaround

Rename file to not include a querystring or use Parcel static #2596
@eonarheim eonarheim changed the title Excalibur gets confused when sound url contains more than one "." Excalibur gets confused when sound url contains a querystring Mar 11, 2023
eonarheim added a commit that referenced this issue Mar 11, 2023
@eonarheim
fix: [#2599] Update Sound canPlayFile to handle querystrings
4bcef0c
@eonarheim eonarheim mentioned this issue Mar 11, 2023
Merged
5 tasks
eonarheim added a commit that referenced this issue Mar 11, 2023
@eonarheim
fix: [#2599] Update Sound canPlayFile to handle querystrings (#2600)
af4a72c 
===:clipboard: PR Checklist :clipboard:===

- [x] :pushpin: issue exists in github for these changes
- [x] :microscope: existing tests still pass
- [x] :see_no_evil: code conforms to the [style guide](https://github.com/excaliburjs/Excalibur/blob/main/STYLEGUIDE.md)
- [x] 📐 new tests written and passing / old tests updated with new scenario(s)
- [x] 📄 changelog entry added (or not needed)

==================

Closes #2599

## Changes:

- Update regex parsing sound paths to determine audio support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [#2599] Update Sound canPlayFile to handle querystrings excaliburjs/Excalibur
1 participant
@eonarheim