New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2599] Update Sound canPlayFile to handle querystrings #2600

Merged

eonarheim merged 2 commits into main from bugfix/2599-sound-file-warning

Mar 11, 2023

Member

eonarheim commented Mar 11, 2023

===:clipboard: PR Checklist :clipboard:===

📌 issue exists in github for these changes
🔬 existing tests still pass
🙈 code conforms to the style guide
📐 new tests written and passing / old tests updated with new scenario(s)
📄 changelog entry added (or not needed)

==================

Closes #2599

Changes:

Update regex parsing sound paths to determine audio support

eonarheim added 2 commits

March 10, 2023 21:25


          fix: [#2599] Update Sound canPlayFile to handle querystrings

4bcef0c


          tweak regex

cc9e504

eonarheim merged commit af4a72c into main

eonarheim deleted the bugfix/2599-sound-file-warning branch

March 11, 2023 03:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet