Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semicolon key command doesn't work in Firefox #789

Closed
jedeen opened this issue Apr 20, 2017 · 2 comments
Closed

Semicolon key command doesn't work in Firefox #789

jedeen opened this issue Apr 20, 2017 · 2 comments
Assignees
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior

Comments

@jedeen
Copy link
Member

jedeen commented Apr 20, 2017

Note: this is not an issue in Google Chrome. There may be other keys that also cause this issue.

Steps to Reproduce

game.input.keyboard.on('down', (keyDown?: ex.Input.KeyEvent) => {
    switch(keyDown.key) {
        case ex.Input.Keys.Semicolon :
            ex.Logger.getInstance().info('semicolon pressed');
            break;
        default :
            ex.Logger.getInstance().warn('unsupported key command');
    }
});

Expected Result

"semicolon pressed"

Actual Result

"unsupported key command"

Environment

  • browsers and versions: Firefox 53.0 (32-bit)
  • operating system: Windows 7
  • Excalibur versions: Excalibur 0.10.0
@jedeen jedeen added the bug This issue describes undesirable, incorrect, or unexpected behavior label Apr 20, 2017
@jedeen jedeen added this to the 0.11.0 Release milestone Apr 20, 2017
@jedeen
Copy link
Member Author

jedeen commented Apr 20, 2017

@kamranayub
Copy link
Member

kamranayub commented Apr 20, 2017 via email

@kamranayub kamranayub self-assigned this May 27, 2017
kamranayub added a commit that referenced this issue Jun 6, 2017
Closes #789

## Changes:

- Normalize semi-colon key on some browsers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

No branches or pull requests

2 participants