Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#789] Normalize semi-colon keycode #825

Merged
merged 4 commits into from
Jun 6, 2017
Merged

[#789] Normalize semi-colon keycode #825

merged 4 commits into from
Jun 6, 2017

Conversation

kamranayub
Copy link
Member

Closes #789

Changes:

  • Normalize semi-colon key on some browsers

Tested in FF 53

@kamranayub kamranayub added the bug This issue describes undesirable, incorrect, or unexpected behavior label May 27, 2017
@kamranayub kamranayub added this to the 0.11.0 Release milestone May 27, 2017
@kamranayub kamranayub requested a review from jedeen May 27, 2017 02:56
eonarheim
eonarheim approved these changes Jun 6, 2017
View reviewed changes
Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

jedeen
jedeen requested changes Jun 6, 2017
View reviewed changes
Copy link
Member

@jedeen jedeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was a bug, can we add a "Fixed" changelog entry?

@kamranayub kamranayub merged commit 27ef69c into master Jun 6, 2017
@kamranayub kamranayub deleted the 789-semicolon branch June 6, 2017 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedeen jedeen jedeen approved these changes

@eonarheim eonarheim eonarheim approved these changes

Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
0.11.0 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@kamranayub @eonarheim @jedeen