Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2353] EdgeColliders in Composite calculate offsets #2354

Merged
merged 4 commits into from
Jun 18, 2022
Merged

fix: [#2353] EdgeColliders in Composite calculate offsets #2354

merged 4 commits into from
Jun 18, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jun 17, 2022 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2353

The PR includes a fix for EdgeColliders when placed into a composite collider

TODOs:

  • Tests
  • More exploration into the issue

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jun 17, 2022
@eonarheim eonarheim merged commit ea9bb13 into main Jun 18, 2022
@eonarheim eonarheim deleted the fix/edge-collider-in-composite branch June 18, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EdgeColliders don't behave properly in a CompositeCollider
1 participant
@eonarheim