-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Fix docutils deprecation in option parsing #842
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
==========================================
- Coverage 90.08% 90.04% -0.05%
==========================================
Files 24 24
Lines 3360 3364 +4
==========================================
+ Hits 3027 3029 +2
- Misses 333 335 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cheers @agoose77! Note some suggestions on a fix were given here: #612 (comment), maybe you want to double check that against your changes here? Will have a proper look later |
Thanks @chrisjsewell — I actually used that issue as a starting point. As such, I'm hopeful that this should fall in line with the recommended changes where possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I think all good cheers
This PR fixes the deprecation warnings raised by docutils' deprecation of
OptionParser
.The help handling is a little ugly - we could introduce a switch on the docutils version like we do for the default settings. However, I think this approach will be less likely to break once the breaking change is introduced.