Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pinned dependency #102

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Remove pinned dependency #102

merged 3 commits into from
Feb 6, 2024

Conversation

willingc
Copy link
Collaborator

@willingc willingc commented Feb 5, 2024

Underlying issue was resolved. Pin is no longer necessary.


📚 Documentation preview 📚: https://docs-community--102.org.readthedocs.build/en/102/

@hugovk
Copy link
Member

hugovk commented Feb 5, 2024

The PR executablebooks/MyST-Parser#842 was merged in December, but hasn't been released yet.

The last release was in June: https://github.com/executablebooks/MyST-Parser/releases

@willingc
Copy link
Collaborator Author

willingc commented Feb 5, 2024

@hugovk Just realized that. I'm going to update this PR with the current SHA.

myst-parser
# myst-parser fixed the docutils warnings. Pinning to current SHA until
# a new release greater than 2.0.0 is made.
git+https://github.com/executablebooks/MyST-Parser.git@978e845543b5bcb7af0ff89cac9f798cb8c16ab3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can ping them to make a new release so that we don't have to pin the SHA?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an issue and pinged Chris: executablebooks/MyST-Parser#870

I'm going to merge the pin for now and we can remove after the release.

@willingc willingc merged commit fdedb64 into python:main Feb 6, 2024
4 checks passed
@willingc willingc deleted the unpin-dep branch February 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants