[2.0]: Major refactoring #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM crystallang/crystal:1.10.1-alpine | |||
| FROM crystallang/crystal:nightly-alpine | |||
There was a problem hiding this comment.
In general we're not in favor of using nightlies, as they're not stable and can cause sudden breakages. What's the reason you need to be on the nightly track?
There was a problem hiding this comment.
I werent planning to merge this pr, I am waiting for the 1.11.x release. That version is almost finished (bug fixes are the only thing merged at this point) so I wanted to test compatibility before the release next week.
There was a problem hiding this comment.
Let me know when you want me to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.