-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0]: Major refactoring #75
Conversation
Dockerfile
Outdated
@@ -1,4 +1,4 @@ | |||
FROM crystallang/crystal:1.10.1-alpine | |||
FROM crystallang/crystal:nightly-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we're not in favor of using nightlies, as they're not stable and can cause sudden breakages. What's the reason you need to be on the nightly track?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I werent planning to merge this pr, I am waiting for the 1.11.x release. That version is almost finished (bug fixes are the only thing merged at this point) so I wanted to test compatibility before the release next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when you want me to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.