Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0]: Major refactoring #75

Merged
merged 6 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM crystallang/crystal:1.10.1-alpine
FROM crystallang/crystal:1.11.2-alpine

# install packages required to run the tests
RUN apk add --no-cache bash jq coreutils
Expand Down
6 changes: 2 additions & 4 deletions bin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@

set -euo pipefail

echo "Building json scaffold helper"
crystal build helpers/scaffold_json.cr --release -o bin/scaffold_json
echo "Building results json helper"
crystal build helpers/result_to_json.cr --release -o bin/result_to_json
echo "Building test_runner"
crystal build src/test_runner.cr --release -o bin/test_runner
echo "Building setup test file helper"
crystal build helpers/setup_test_file.cr --release -o bin/setup_test_file
3 changes: 1 addition & 2 deletions bin/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ echo "${slug}: testing..."
# stderr to capture it
crystal spec "${modified_spec_file}" --junit_output="${output_dir}" --no-color &> "${capture_file}"

./bin/scaffold_json "${spec_file}" "${scaffold_file}"
./bin/result_to_json "${capture_file}" "${junit_file}" "${scaffold_file}" "${results_file}"
./bin/test_runner "${spec_file}" "${capture_file}" "${junit_file}" "${results_file}"

echo "${slug}: done"
12 changes: 11 additions & 1 deletion changelog.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
# 2.0

- Move to Crystal 1.11.2
- Refactored test runner
- Going from three exectuables down to two
- Improved build time
- Simplify the scripts to make them easier to maintain.
This includes around a 40-50 percent reduction of lines of code
- Improved documentation

# 1.2

- Move to Crystal 1.10.x
- Move to Crystal 1.10.1
- Limit output to 500 characters

# 1.1.0
Expand Down
179 changes: 0 additions & 179 deletions helpers/result_to_json.cr

This file was deleted.

155 changes: 0 additions & 155 deletions helpers/scaffold_json.cr

This file was deleted.

Loading