Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hangman: implement exercise #745

Closed
ilya-khadykin opened this issue Oct 6, 2017 · 13 comments
Closed

hangman: implement exercise #745

ilya-khadykin opened this issue Oct 6, 2017 · 13 comments

Comments

@ilya-khadykin
Copy link
Contributor

There are exercises that are not yet implemented in Python track (the full list of them - #417 (comment)).
You can help us change this situation by implementing this one. Ref #417

The guide "Implement an exercise from specification" will help you succeed.

If you still have questions, I encourage you to ask them before starting working on the issue.

I also suggest claiming the issue by creating an empty PR as stated here

Please note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
This simple thing helps us a lot, and makes our life a bit easier

@vaibhavsingh97
Copy link

can i take up this issue?

@ilya-khadykin
Copy link
Contributor Author

@stale
Copy link

stale bot commented Nov 23, 2017

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@khoa102
Copy link

khoa102 commented Jan 9, 2018

Hi, I wonder if I can take up this issues as my first contribution for open source?

@cmccandless
Copy link
Contributor

@khoa102 Absolutely! Issues can be claimed by creating a PR for them. Please remember to put Fixes #745 in the PR description to link the PR to this issue.

@khoa102
Copy link

khoa102 commented Jan 10, 2018

Great! @cmccandless

@khoa102
Copy link

khoa102 commented Jan 12, 2018

Hi, can anyone take a look at the PR for this issue that I submit a few day ago? I would also want to know what should I put for the config of this exercise, like the difficulty, unlock or topic?

@anshima1
Copy link

anshima1 commented Oct 2, 2018

Hey is this issue solved? If not, I'll like to work on it.

@cmccandless
Copy link
Contributor

@anshima1 No, this issue is not yet resolved.

If you wish to work on this, I highly suggest reviewing the discussion in #1160.

@junming403
Copy link
Contributor

junming403 commented Feb 26, 2019

Hi is this issue still relevant? I would like to work on it. Do i need to open an PR to claim it first?

@cmccandless
Copy link
Contributor

@junming403 It is still relevant, yes.

Also, as stated above:

If you wish to work on this, I highly suggest reviewing the discussion in #1160.

@junming403
Copy link
Contributor

Hi thank you for the prompt response! I have looked at the thread of discussion. Notice it did not use FRP, I am considering make this exercise based on FRP library(http://reactivex.io/intro.html). What should do if the exercise rely on the library? Any guidance?

@cmccandless
Copy link
Contributor

RE: the track README

We use unittest (Python Standard Library) and no 3rd-party-framework.

It would be preferable that we stick to that.

cmccandless pushed a commit that referenced this issue Mar 4, 2019
Fixes #745 

Solution based on the work of #1160

Config file lint with tool `configlet`, shall I keep all the changes in the config?

Ready for review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants