[WIP] Fix audio crashes and leaks; add stress tests #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename examples
Add null check to requestAnimationFrame sorting
Fix terminal example
Bugfix requestAnimationFrame chaining
Add rAF/timeout/interval defaults
Add WebGL version flag
Minor package.json update
added 15 commits
August 4, 2018 20:52
Fix MacOS WebGL2 shader transpilation
Fix WebGL2 Web Worker initialization
Throttle vrdisplayactivate
Bugfix window resize events
|
Perhaps adding comments or adding to PR description what was wrong, and what the code does to fix it? |
avaer
changed the title
|
Definitely, this is a WIP; marked it as such. I have a bunch more code floating for this that's very close to a fix but it needs to be unstashed, pushed, and documented. I'll see if I can pull it out. |
|
Pulling out the hacks to https://github.com/webmixedreality/exokit/tree/audio-leak-2. Still needs a writeup. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174.
Resurrection of #285.