Add gzipped jsonl reader #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a simple modification to the jsonl reader that unzips a file. If the API instead of just allowing a path also allowed to pass in a file stream I could have handled it outside of this, but this seems the most straightforward solutions atm.
|
Hi @RXminuS, thanks for your contribution! This would be a useful feature. Before considering this for merging, we'd like this PR to also:
Be aware that your current code is not valid Python. Let me know if you'd like to continue working on this! :-) |
2 tasks
|
Implemented in #84. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple modification to the jsonl reader that unzips a file. If the API instead of just allowing a path also allowed to pass in a file stream I could have handled it outside of this, but this seems the most straightforward solutions atm.