Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality for gzipped .jsonl reading and writing #84

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Add functionality for gzipped .jsonl reading and writing #84

merged 6 commits into from
Feb 17, 2023

Conversation

rmitsch
Copy link
Contributor

@rmitsch rmitsch commented Feb 14, 2023 •
edited
Loading

Description

Add functionality for gzipped .jsonl reading and writing + tests and docs update. Thanks to @RXminuS for submitting a first PR for this.
Unrelated formatting changes in readme are due to running prettier on it.

Types of change

New feature.

Checklist

  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added the enhancement New feature or request label Feb 14, 2023
@rmitsch rmitsch self-assigned this Feb 14, 2023
@rmitsch rmitsch mentioned this pull request Feb 14, 2023
Closed
@adrianeboyd
Copy link
Contributor

Thanks! append_new_line=True seems weird, but consistent with the existing methods.

@adrianeboyd adrianeboyd merged commit c85da00 into explosion:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianeboyd adrianeboyd adrianeboyd left review comments

Assignees

@rmitsch rmitsch

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmitsch @adrianeboyd