Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] make less gql calls fingerprint:compare #2860

Merged

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Feb 3, 2025

Why

Fast follow up from #2859

Simplify the project owner account retrieval by using the nested ownerAccount field from the project query instead of making a separate API call.

How

  • Removed the separate getOwnerAccountForProjectIdAsync call
  • Access the owner account name directly through project.ownerAccount.name
  • This reduces API calls and simplifies the code path for non-interactive update group selection

Test Plan

Ran eas fingerprint:compare

Copy link
Member Author

quinlanj commented Feb 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@quinlanj quinlanj marked this pull request as ready for review February 3, 2025 23:53
Copy link

github-actions bot commented Feb 3, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 3, 2025

Size Change: -701 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -701 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.32%. Comparing base (365e71f) to head (62a84df).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/eas-cli/src/commands/fingerprint/compare.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
- Coverage   52.33%   52.32%   -0.01%     
==========================================
  Files         588      588              
  Lines       23137    23145       +8     
  Branches     4848     4849       +1     
==========================================
+ Hits        12107    12108       +1     
- Misses      10056    10062       +6     
- Partials      974      975       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 4, 2025

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit 1b78407 into main Feb 4, 2025
7 checks passed
@quinlanj quinlanj deleted the 02-03-_eas-cli_make_less_gql_calls_fingerprint_compare branch February 4, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants