Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] make less gql calls fingerprint:compare #2860

Merged
merged 3 commits into from
Feb 4, 2025
Merged

[eas-cli] make less gql calls fingerprint:compare #2860

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcc74ec
[eas-cli] make less gql calls fingerprint:compare
quinlanj Feb 3, 2025
88ab70f
Temporary Commit at 2/3/2025, 3:54:11 PM
quinlanj Feb 3, 2025
62a84df
Merge branch 'main' into 02-03-_eas-cli_make_less_gql_calls_fingerpri…
quinlanj Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ This is the log of notable changes to EAS CLI and related packages.
- Add update group id support for fingerprint:compare. ([#2851](https://github.com/expo/eas-cli/pull/2851) by [@quinlanj](https://github.com/quinlanj))
- Add better interactive support for fingerprint:compare. ([#2854](https://github.com/expo/eas-cli/pull/2854) by [@quinlanj](https://github.com/quinlanj))
- Popup website in fingerprint:compare. ([#2859](https://github.com/expo/eas-cli/pull/2859) by [@quinlanj](https://github.com/quinlanj))
- Make less gql calls in fingerprint:compare. ([#2860](https://github.com/expo/eas-cli/pull/2860) by [@quinlanj](https://github.com/quinlanj))

## [14.7.1](https://github.com/expo/eas-cli/releases/tag/v14.7.1) - 2025-01-31

Expand Down
12 changes: 3 additions & 9 deletions packages/eas-cli/src/commands/fingerprint/compare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ import Log from '../../log';
import { ora } from '../../ora';
import { RequestedPlatform } from '../../platform';
import { maybeUploadFingerprintAsync } from '../../project/maybeUploadFingerprintAsync';
import {
getDisplayNameForProjectIdAsync,
getOwnerAccountForProjectIdAsync,
} from '../../project/projectUtils';
import { getDisplayNameForProjectIdAsync } from '../../project/projectUtils';
import { resolveWorkflowPerPlatformAsync } from '../../project/workflow';
import { promptAsync, selectAsync } from '../../prompts';
import { selectUpdateGroupOnBranchAsync } from '../../update/queries';
Expand Down Expand Up @@ -514,13 +511,10 @@ async function getFingerprintInfoFromUpdateGroupIdOrUpdateIdAsync(
return await getFingerprintFromUpdateFragmentAsync(update);
}
if (nonInteractive) {
const [accountName, project] = await Promise.all([
(await getOwnerAccountForProjectIdAsync(graphqlClient, projectId)).name,
AppQuery.byIdAsync(graphqlClient, projectId),
]);
const project = await AppQuery.byIdAsync(graphqlClient, projectId);
const updateUrl =
getExpoWebsiteBaseUrl() +
`/accounts/${accountName}/projects/${project.name}/updates/${maybeUpdateGroupId}`;
`/accounts/${project.ownerAccount.name}/projects/${project.name}/updates/${maybeUpdateGroupId}`;
throw new Error(
`Please pass in your update ID from ${updateUrl} or use interactive mode to select the update ID.`
);
Expand Down