[android][media-library] With media management permission, addAssetsToAlbumAsync fails on albums containing folders

[Nafeij]

Minimal reproducible example

https://github.com/Nafeij/my-app

What platform(s) does this occur on?

Android

Where did you reproduce the issue?

in a development build

Summary

expo/packages/expo-media-library/android/src/main/java/expo/modules/medialibrary/albums/AddAssetsToAlbum.kt

Line 48 in 138283b

if (!fileInAlbum.isFile) {

When adding assets to an album, the above check is performed with the assumption that this is a migrated or app-created album. However, it is still possible for apps to obtain MANAGE_MEDIA permissions and operate on external albums, which may themselves contain nested albums or folders. In this case, an unexpected error is thrown stating that the Media Library is corrupted.

To reproduce:

Prepare an album containing an image and a folder and run the reproducible example to add another image to said album.

Environment

expo-env-info 1.2.0 environment info:
    System:
      OS: Windows 11 10.0.22631
    Binaries:
      Node: 20.13.1 - C:\Program Files\nodejs\node.EXE
      Yarn: 1.22.19 - C:\Program Files\nodejs\yarn.CMD
      npm: 10.5.2 - C:\Program Files\nodejs\npm.CMD
    IDEs:
      Android Studio: AI-241.15989.150.2411.11948838
    npmPackages:
      expo: ~51.0.24 => 51.0.24 
      expo-router: ~3.5.20 => 3.5.20 
      react: 18.2.0 => 18.2.0 
      react-dom: 18.2.0 => 18.2.0 
      react-native: 0.74.3 => 0.74.3 
      react-native-web: ~0.19.10 => 0.19.12 
    Expo Workflow: bare

Expo Doctor Diagnostics

✔ Check Expo config for common issues
✔ Check package.json for common issues
✔ Check native tooling versions
✔ Check dependencies for packages that should not be installed directly
✔ Check for common project setup issues
✔ Check for issues with metro config
✔ Check npm/ yarn versions
✔ Check Expo config (app.json/ app.config.js) schema
✔ Check for legacy global CLI installed locally
✔ Check that packages match versions required by installed Expo SDK
✔ Check that native modules do not use incompatible support packages
✔ Check that native modules use compatible support package versions for installed Expo SDK

Didn't find any issues with the project!