[android][media-library] update check for album corruption #31027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nafeij
force-pushed
the
fix/allow-nested-albums
branch
from
2a226c9 to
62207df
Compare
expo-bot
added
bot: passed checks
behenate
reviewed
Aug 27, 2024
...xpo-media-library/android/src/main/java/expo/modules/medialibrary/albums/AddAssetsToAlbum.kt
Outdated
Show resolved
Hide resolved
Nafeij
changed the title
behenate
approved these changes
Aug 28, 2024
|
@Nafeij Thank you for the contribution! |
behenate
pushed a commit
that referenced
this pull request
Sep 30, 2024
# Why We can't assume an album is corrupted because it contains non-files. In an app with file manager perms, it's possible for expo to access external albums which may be nested or otherwise contain directories. Closes #30869 ~~Also feel free to suggest alternative checks.~~ We should also check if the non-file is a non-directory (#31027 (comment)) # How <!-- How did you build this feature or fix this bug and why? --> Add an additional check to prevent the exception being thrown for nested but otherwise valid albums. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> See the `Minimal reproducible example` in #30869 to reproduce original behavior. Before: https://github.com/user-attachments/assets/f6edbc3f-2850-4ae6-97fd-12caa8ce4ae9 After: https://github.com/user-attachments/assets/8527535f-5926-488f-82fd-bd6ee82956aa # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
nathan-ahn
pushed a commit
to nathan-ahn/expo-media-library
that referenced
this pull request
Nov 13, 2024
# Why We can't assume an album is corrupted because it contains non-files. In an app with file manager perms, it's possible for expo to access external albums which may be nested or otherwise contain directories. Closes #30869 ~~Also feel free to suggest alternative checks.~~ We should also check if the non-file is a non-directory (expo/expo#31027 (comment)) # How <!-- How did you build this feature or fix this bug and why? --> Add an additional check to prevent the exception being thrown for nested but otherwise valid albums. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> See the `Minimal reproducible example` in #30869 to reproduce original behavior. Before: https://github.com/user-attachments/assets/f6edbc3f-2850-4ae6-97fd-12caa8ce4ae9 After: https://github.com/user-attachments/assets/8527535f-5926-488f-82fd-bd6ee82956aa # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We can't assume an album is corrupted because it contains non-files. In an app with file manager perms, it's possible for expo to access external albums which may be nested or otherwise contain directories.
Closes #30869
Also feel free to suggest alternative checks.We should also check if the non-file is a non-directory (#31027 (comment))How
Add an additional check to prevent the exception being thrown for nested but otherwise valid albums.
Test Plan
See the
Minimal reproducible examplein #30869 to reproduce original behavior.Before:
Recording.2024-08-16.162301.mp4
After:
Recording.2024-08-16.164251.mp4
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).