Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[contacts][Android] Migrate codebase to use Expo Modules API #24991

Merged
merged 3 commits into from
Oct 30, 2023
Merged

[contacts][Android] Migrate codebase to use Expo Modules API #24991

merged 3 commits into from
Oct 30, 2023

Conversation

lukmccall
Copy link
Contributor

Why

Migrates expo-contacts to new API.

How

  • rewrite using Kotlin
  • migrated module file to use new API

👋 Note
I didn't want to change the behavior in this PR, so some places aren't as clean as possible. Probably, I'll do a second PR in the future where I expose a better API.

Test Plan

  • test-suite ✅

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 23, 2023
reichhartd
reichhartd reviewed Oct 23, 2023
View reviewed changes
packages/expo-modules-core/expo-module.config.json Outdated
Comment on lines 6 to 8
},
"android": {
"modules": ["expo.modules.contacts.ContactsModule"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the wrong expo-module.config.json 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😂 👀

@lukmccall lukmccall force-pushed the @lukmccall/contacts/migrate-to-new-api branch from 91058aa to 404288c Compare October 30, 2023 10:42
@lukmccall @expo-bot
[skip ci] Update packages/expo-contacts/CHANGELOG.md
52e6d97 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@lukmccall lukmccall merged commit b1d1904 into main Oct 30, 2023
1 check passed
@lukmccall lukmccall deleted the @lukmccall/contacts/migrate-to-new-api branch October 30, 2023 15:53
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reichhartd reichhartd reichhartd left review comments

@Kudo Kudo Kudo approved these changes

@tsapeta tsapeta Awaiting requested review from tsapeta

@EvanBacon EvanBacon Awaiting requested review from EvanBacon

Assignees
No one assigned
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukmccall @Kudo @tsapeta @reichhartd @expo-bot