Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contacts][Android] Migrate codebase to use Expo Modules API #24991

Merged
merged 3 commits into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import expo.modules.cellular.CellularModule
import expo.modules.clipboard.ClipboardModule
import expo.modules.constants.ConstantsModule
import expo.modules.constants.ConstantsPackage
import expo.modules.contacts.ContactsPackage
import expo.modules.contacts.ContactsModule
import expo.modules.core.interfaces.Package
import expo.modules.crypto.CryptoModule
import expo.modules.device.DeviceModule
Expand Down Expand Up @@ -87,7 +87,6 @@ object ExperiencePackagePicker : ModulesProvider {
AVPackage(),
BarCodeScannerPackage(),
ConstantsPackage(),
ContactsPackage(),
FaceDetectorPackage(),
FileSystemPackage(),
ImageLoaderPackage(),
Expand Down Expand Up @@ -147,6 +146,7 @@ object ExperiencePackagePicker : ModulesProvider {
ClipboardModule::class.java,
CryptoModule::class.java,
ConstantsModule::class.java,
ContactsModule::class.java,
DeviceModule::class.java,
DocumentPickerModule::class.java,
EASClientModule::class.java,
Expand Down
1 change: 1 addition & 0 deletions packages/expo-contacts/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
### 💡 Others

- Renamed `unimodule.json` to `expo-module.config.json`. ([#25100](https://github.com/expo/expo/pull/25100) by [@reichhartd](https://github.com/reichhartd))
- Migrated codebase to use Expo Modules API. ([#24991](https://github.com/expo/expo/pull/24991) by [@lukmccall](https://github.com/lukmccall))

## 12.6.0 — 2023-10-17

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package expo.modules.contacts

import android.provider.ContactsContract

object Columns {
const val DATA_10 = "data10"
const val DATA_9 = "data9"
const val DATA_8 = "data8"
const val DATA_7 = "data7"
const val DATA_6 = "data6"
const val DATA_5 = "data5"
const val DATA_4 = "data4"
const val LABEL = "data3"
const val TYPE = "data2"
const val DATA = "data1"
const val ID = ContactsContract.Data._ID
const val IS_PRIMARY = ContactsContract.Data.IS_PRIMARY
const val CONTACT_ID = ContactsContract.Data.CONTACT_ID
const val LOOKUP_KEY = ContactsContract.Data.LOOKUP_KEY
const val DISPLAY_NAME = ContactsContract.Data.DISPLAY_NAME
const val PHOTO_URI = ContactsContract.CommonDataKinds.Contactables.PHOTO_URI
const val PHOTO_THUMBNAIL_URI = ContactsContract.CommonDataKinds.Contactables.PHOTO_THUMBNAIL_URI
const val IS_USER_PROFILE = ContactsContract.CommonDataKinds.Contactables.IS_USER_PROFILE
const val MIMETYPE = ContactsContract.Data.MIMETYPE
const val TYPE_CUSTOM = 0
}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package expo.modules.contacts

interface CommonProvider {
val contentType: String
val dataAlias: String
val labelAlias: String
val idAlias: String
}
Loading