Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): use proper evaluation and stack traces based on source maps #443

Merged
merged 5 commits into from
Jul 18, 2023
Merged

fix(runtime): use proper evaluation and stack traces based on source maps #443

merged 5 commits into from
Jul 18, 2023

Conversation

byCedric
Copy link
Member

Why

Before After
Stack traces before this fix Stack traces after this fix

How

  • Updated code evaluation to use the newer globalEvalWithSourceUrl (see this)
  • Updated the error summary generator (prettyStack)
  • Fixed an unexpected newline being generated after applyPatch('', ...)

Test Plan

See staging.

@byCedric byCedric requested a review from Kudo July 17, 2023 16:57
@byCedric byCedric assigned EvanBacon and unassigned EvanBacon Jul 17, 2023
@byCedric byCedric requested a review from EvanBacon July 17, 2023 16:57
@byCedric byCedric temporarily deployed to runtime-staging July 17, 2023 17:04 — with GitHub Actions Inactive
@byCedric
Copy link
Member Author

byCedric commented Jul 17, 2023 •
edited
Loading

Note, web needs more fixes. Seems that window.onerror is blocked somehow.

Could be related to iframe allow issues, should be a different PR.

@byCedric byCedric temporarily deployed to runtime-staging July 17, 2023 17:26 — with GitHub Actions Inactive
@byCedric byCedric merged commit deeeb3a into main Jul 18, 2023
@byCedric byCedric deleted the @bycedric/runtime/source-maps branch July 18, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kudo Kudo Awaiting requested review from Kudo

@EvanBacon EvanBacon Awaiting requested review from EvanBacon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byCedric @EvanBacon