Release 2.0 #66

dougwilson · 2014-10-30T01:38:44Z

This is a tracking issue for release 2.0.

I am trying to give better visibility for upcoming changes and so am trying out making a PR for a release here, pulling from the official next release branch into master. This allows for the current pending changes to be easily visible.

Please keep feature requests in their own issues

I'm also leaving this PR unlocked so people can make comments/etc. and we'll see how it goes :) If you want to make a comment on a particular change, please make the comment in the "Files changed" tab so comments are not lost during a rebase.

List of changes for release:

List of deprecated things removed:

Main bodyParser() function which did urlencoded + json

Testing this release

If you want to try out this release, you can install it with the following command:

$ npm cache clean
$ npm install expressjs/body-parser#2.x
$ npm cache clean

Fishrock123 · 2014-10-30T01:42:03Z

@dougwilson isn't abstraction from parsers or whatever scheduled-ish for 2.0?

dougwilson · 2014-10-30T01:43:08Z

Yea, I haven't fully added everything to the checklist yet. I just wanted to make the PR so it starts to get eyes.

LinusU · 2015-08-03T09:39:25Z

@dougwilson Would love to use this, have you thought about publishing to npm as 2.0.0-beta1? Thanks 👍

dougwilson · 2015-08-28T00:50:23Z

Hey @LinusU ! I never published it because I didn't think there was anyone wanting to start, so without demand, I did not want to burden myself with maintaining two working release lines at once, if it wasn't necessary. I'll see about getting a alpha/beta out, though :) You can always add a branch/commit of a git repo as an npm dependency, though.

LinusU · 2015-08-28T09:44:31Z

Cool. I mainly wanted the first bullet which caused a bug for me when only using the raw middleware. But I just worked around it in code since I still want to get bugfixes. Would be cool to get 2.0 out for real thought. Whats missing? Is there anything I can help with?

theganyo · 2015-11-06T00:13:53Z

Hey @dougwilson! So I just found this because of the bugs I've been battling today related to #128, but I see the issue and this PR have been open for over a year despite being fixed. Since it doesn't look like this is going to happen (or is there still a chance?), is the only option to fork and release under a different name?

dougwilson · 2015-11-06T00:30:37Z

Hi @theganyo , you are certainly welcome to fork & release this under another module, as it is under the MIT license, but there are a few reasons why it has yet to be released:

I had a report that the changes in here can sometimes stall out a request. I have not been able to look, but if you would like to test it out on your systems (using the instructions provided in the original post), that would be much appreciated!
This was proposed over a year ago, but with Express 3.x still supported and relying on this module, it was not possible to release a breaking version without adding more work for myself, which is all done unpaid, and so I've been waiting for Express 3.x to go away first.

is the only option to fork and release under a different name?

You can always depend on the branch in GitHub in your package.json... https://docs.npmjs.com/files/package.json#git-urls-as-dependencies

dougwilson · 2015-11-06T00:32:46Z

And since Express 3.x is now "officially unsupported", I want to just make one last 1.x release here and then publish a 2.0.0 alpha for people to start testing on.

theganyo · 2015-11-06T00:37:31Z

Thanks, Doug. As you might have guessed, forking and releasing isn't at top of my list of alternatives. :) I just wanted to gauge whether this was really still potentially going to be supported. Since you're looking at a new release, I'll just hack around it for now and update later. Thanks for the quick reply!

* Always use the qs module, even in simple mode #326 (comment) * Create the simple and extended parser with the same function, reducing duplication * Don't mention the querystring module in the README * Fix lint

UlisesGascon

Please don't release 2.0 before I approve this PR.

Based on a private discussion, I want to include a major change that has not been made public yet.

…326) * urlencoded, in extended mode: Support iso-8859-1 encoded requests, and also accept iso-8859-1 as a default encoding. * urlencoded: Support an utf8 sentinel to detect the charset. * Pass the interpretNumericEntities option through to qs. * Fix lint * Support charsets, sentinels etc. via custom decoders Works in both extended and simple mode. * Simplify * Fix empty parameter issue with utf8Sentinel in simple mode * Run all the charset/sentinel tests in both extended and simple modes * utf8Sentinel => charsetSentinel ljharb/qs#268 (comment) * Update qs to 6.9.1 * Always use the qs module, even in simple mode #326 (comment) * Create the simple and extended parser with the same function, reducing duplication * Don't mention the querystring module in the README * Fix lint * Update qs to 6.9.4 * Consistently call it "utf8 sentinel" * Simplify by relying on the qs module's support for detecting the charset #326 (comment) * Simplify further * Put back debug option * Document that defaultCharset defaults to utf-8 #326 (comment)

UlisesGascon · 2024-07-31T18:55:29Z

Just to confirm @wesleytodd... only my change is missing for releasing it? Do you want to work on the conflicts?

wesleytodd · 2024-08-02T01:42:40Z

I was going to work out the conflicts after updating all the deps and stuff. I think I looked at them when I tried to rebase this and it was enough questions I needed more time which I didn't have then. I was thinking that it would be easiest to do all that resolution at the same time right before publishing than doing it now and possibly having to do it again later.

RobinTail · 2024-08-16T14:03:25Z

I want to include a major change that has not been made public yet.

What's been holding you from doing that yet, @UlisesGascon?
3 weeks passed. This package is a blocker for Express 5.

wesleytodd · 2024-08-16T14:06:18Z

Hey @RobinTail, I appreciate the energy to keep things moving. That said, there are things going on behind the scenes which you are likely not aware of. If you would like to help out with that work, please come to our working sessions or start helping with other efforts and then we can include you in the non-public discussions. In the mean time, please know that the delays here are 100% necessary and intentional.

- Update documentation to reflect the new features and errors - Update the changelog - Upgrade to `qs@6.13.0` - Add the `depth` option to define the depth of parsing while parsing the query string - Enable the `strictDepth` option by default in `qs.parse` - Add a 400 status code when the depth of the query string exceeds the limit defined by the `depth` option - Reduce the default depth limit to 32

UlisesGascon

LGTM! Finally we are releasing it ! 🥳

dougwilson added pr release labels Oct 30, 2014

dougwilson force-pushed the 2.x branch 2 times, most recently from 1e34bc4 to d3021d6 Compare October 30, 2014 02:04

dougwilson self-assigned this Feb 23, 2015

dougwilson force-pushed the master branch from 6635cd5 to 6b6c52c Compare May 11, 2015 04:27

This was referenced Sep 11, 2015

Calling bodyParse.json() with empty body causes the req.body to be replaced with an empty object #123

Closed

text bodyParser sets object when body is empty #128

Closed

dougwilson mentioned this pull request Jan 29, 2016

support "err instanceof http-errors" for all individual errors jshttp/http-errors#22

Closed

This was referenced Jul 30, 2016

Fix for raw() parser if body is empty #188

Closed

raw() parser: if body is empty, req.body is set to empty object #187

Closed

dougwilson added the needs rebase label Jan 16, 2017

dougwilson force-pushed the master branch from 7c962f4 to 9437df9 Compare September 9, 2017 00:32

dougwilson mentioned this pull request Sep 27, 2017

Parsers set body even when they should not parse #269

Closed

dougwilson force-pushed the master branch from c4b9a0b to 0f75d30 Compare May 8, 2018 19:36

dougwilson added this to the 2.0 milestone Apr 23, 2020

gireeshpunathil mentioned this pull request Apr 23, 2020

express 5.0.0 expressjs/discussions#100

Closed

Default urlencoded extended option to false

9eb206b

dougwilson force-pushed the 2.x branch from d4659d2 to 8e4def6 Compare December 16, 2021 05:16

dougwilson added 2 commits December 16, 2021 00:17

Use on-finished to determine when body read

08d95a4

Remove req.body initialization to {}

6cbc279

dougwilson added 6 commits February 21, 2023 21:22

deps: iconv-lite@0.5.2

28192d6

deps: debug@3.1.0

f8424b1

build: remove conditional code coverage

42de1bf

Remove deprecated bodyParser() combination middleware

4d7b821

tests: enable strict mode

87e60af

docs: add missing history entry

b53363c

dougwilson force-pushed the 2.x branch from 0db98e1 to b53363c Compare February 23, 2023 21:54

2.0.0-beta.2

fccaf48

wesleytodd mentioned this pull request May 8, 2024

Express 5.0 - last push! expressjs/discussions#233

Closed

46 tasks

ctcpip mentioned this pull request May 31, 2024

rebase: Generic Body Parser implemented #524

Open

feat!: remove node less than 18 from ci

ddf9b75

wesleytodd mentioned this pull request Jul 22, 2024

Release 3.0 stream-utils/raw-body#87

Merged

4 tasks

papandreou and others added 2 commits July 24, 2024 16:38

Also use the qs module for the simple parser (#387)

7eb00cd

* Always use the qs module, even in simple mode #326 (comment) * Create the simple and extended parser with the same function, reducing duplication * Don't mention the querystring module in the README * Fix lint

fix(deps): raw-body@^3.0.0 (#529)

35b50b5

UlisesGascon requested changes Jul 26, 2024

View reviewed changes

wojtekmaj mentioned this pull request Aug 7, 2024

feat: qs -> neoqs #530

Open

wesleytodd mentioned this pull request Aug 7, 2024

Update iconv-lite to latest 0.6.3 #476

Closed

danielgindi and others added 3 commits August 17, 2024 13:42

Added support for brotli ('br') content-encoding (#406)

07ce14d

Merge branch 'master' into 2.x

9232c77

wesleytodd approved these changes Sep 10, 2024

View reviewed changes

UlisesGascon approved these changes Sep 10, 2024

View reviewed changes

2.0.0

a50ab74

UlisesGascon force-pushed the 2.x branch from 9aa675b to a50ab74 Compare September 10, 2024 03:14

wesleytodd merged commit a50ab74 into master Sep 10, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2.0 #66

Release 2.0 #66

dougwilson commented Oct 30, 2014 •

edited by UlisesGascon

Loading

Fishrock123 commented Oct 30, 2014

dougwilson commented Oct 30, 2014

LinusU commented Aug 3, 2015

dougwilson commented Aug 28, 2015

LinusU commented Aug 28, 2015

theganyo commented Nov 6, 2015

dougwilson commented Nov 6, 2015

dougwilson commented Nov 6, 2015

theganyo commented Nov 6, 2015

UlisesGascon left a comment

UlisesGascon commented Jul 31, 2024

wesleytodd commented Aug 2, 2024

RobinTail commented Aug 16, 2024

wesleytodd commented Aug 16, 2024

UlisesGascon left a comment

Release 2.0 #66

Release 2.0 #66

Conversation

dougwilson commented Oct 30, 2014 • edited by UlisesGascon Loading

Fishrock123 commented Oct 30, 2014

dougwilson commented Oct 30, 2014

LinusU commented Aug 3, 2015

dougwilson commented Aug 28, 2015

LinusU commented Aug 28, 2015

theganyo commented Nov 6, 2015

dougwilson commented Nov 6, 2015

dougwilson commented Nov 6, 2015

theganyo commented Nov 6, 2015

UlisesGascon left a comment

Choose a reason for hiding this comment

UlisesGascon commented Jul 31, 2024

wesleytodd commented Aug 2, 2024

RobinTail commented Aug 16, 2024

wesleytodd commented Aug 16, 2024

UlisesGascon left a comment

Choose a reason for hiding this comment

dougwilson commented Oct 30, 2014 •

edited by UlisesGascon

Loading