send@1.0.0 #5786
Merged
send@1.0.0 #5786
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
approved these changes
Jul 26, 2024
|
Yeah we do, that said longer term I really want to get us on a tool to automate this. Release Please ideally. We don't even need to auto publish, but just generating the changelog and opening the PR would be awesome. EDIT: I will update that when we get the CI working again and are ready to merge. |
|
I think that since we plan on fixing up the CI in separate PRs I don't want to let this sit and have to update the branch again for such a small change which is guaranteed to land. Also, just pushed an update for the history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
send@^1.0.0.The failure in CI is expected until we land #5595 because send dropped node versions. It looks like we explicitly break <6 with this.