Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade send to 1.0.0 #5817

Closed
wants to merge 1 commit into from
Closed

Conversation

benmccann
Copy link

@benmccann benmccann commented Aug 8, 2024

Why don't you use ^ anywhere and why do only some have ~? By pinning all these versions you prevent dependency deduping. There are two versions of send in the dependency tree, which makes the dependency tree much larger: https://npmgraph.js.org/?q=express@5.0.0-beta.3

@wesleytodd
Copy link
Member

Why don't you use ^ anywhere and why do only some have ~?

When v4 was released some npm versions were still in use which did not support ^ IIRC. Anyway, it was so long ago it is not applicable anymore, just a matter of getting things updated. And yes, we are well aware of the issues around deduping.

There are two versions of send in the dependency tree

In the v5 branch, the work to update all the dependencies is ongoing. In this case, it is already covered in #5786

Thanks for the PR, but I am going to close it in favor of the already exiting one.

@wesleytodd wesleytodd closed this Aug 8, 2024
@benmccann
Copy link
Author

Thanks! Sorry I missed that there was an already open PR for this!

@benmccann benmccann deleted the patch-1 branch August 8, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants