Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module: 'ES2022', support newer moduleResolution kinds, support cts + mts #447

Closed
wants to merge 9 commits into from

Conversation

ezolenko
Copy link
Owner

@ezolenko ezolenko commented May 20, 2023

Summary

Fix for #437

Details

  • keeping node* moduleResolution option as is ("node", "node16", "nodenext")
  • overriding "classic" and empty to Node10 (old behavior was overriding everything to Node10)
  • overriding "bundler" to Node16

@ezolenko ezolenko closed this Jun 20, 2023
@agilgur5 agilgur5 changed the title updating module overrides add module: 'ES2022', update moduleResolution default to node16, add cts + `mts Jun 30, 2023
@agilgur5 agilgur5 changed the title add module: 'ES2022', update moduleResolution default to node16, add cts + `mts add module: 'ES2022', update moduleResolution default to node16, add cts + mts Jun 30, 2023
@agilgur5
Copy link
Collaborator

Replaced by #453

@agilgur5
Copy link
Collaborator

Or rather, this got split into multiple PRs it looks like:

Much nicer and easier to read as separate PRs!

dist/parse-tsconfig.d.ts Show resolved Hide resolved
src/get-options-overrides.ts Show resolved Hide resolved
@agilgur5 agilgur5 changed the title add module: 'ES2022', update moduleResolution default to node16, add cts + mts add module: 'ES2022', support moduleResolution overrides, support cts + mts Jun 30, 2023
@agilgur5 agilgur5 changed the title add module: 'ES2022', support moduleResolution overrides, support cts + mts add module: 'ES2022', support newer moduleResolution kinds, support cts + mts Jun 30, 2023
@ezolenko
Copy link
Owner Author

Yeah, ignore that PR, I started too many changes at once and updated deps too far and that required yet more changes and so on (we'd still have to figure out ts-jest problems eventually I guess). All interesting changes are pulled out into those 3 PRs

@agilgur5
Copy link
Collaborator

Ah right, ts-jest is having issues because jest's ESM support is still experimental, meaning some CJS is still needed. ts-jest now has some support too now though, so might be able to get it to work that way.

EDIT: welp, that gives even more problems because some of the test code does not work in ESM mode (e.g. __dirname, require for tslib, and imports of CJS packages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants