deps: bump Rollup peerDep to 3.7.5+, remove tech debt #458
Conversation
src/index.ts
Outdated
| if (err || !pluginOptions.check) | ||
| return buildDone(); |
There was a problem hiding this comment.
the logic here is a bit confusing -- I had to re-read my own code a few times.
Basically, I made sure the diff was functionally equivalent to the previous one, minus the error rewriting.
this.error causes an exit and return will similarly end the function.
If there's an error, we just want to call cache.done() (as buildDone() does) and otherwise let the error proceed.
If we're not doing type-checking, we can return early as the code below is only relevant when type-checking
|
Left this as a Draft PR for now as it is breaking, and I think we should get in a patch release and stabilize MTS/CTS support beforehand. #453 would be ideal to get in beforehand as well, although that is technically a breaking change as well And potentially there is more tech debt we want to remove in this PR as well; thought I might be missing something? |
agilgur5
force-pushed
the
deps-upgrade-rollup
branch
from
ebbf16b
to
86d987d
Compare
- 3.7.5 includes rollup/rollup@ffab4cd - which fixes the duplicate error logging upstream and allows us to remove the `buildEnd` workaround - 2.60.0 includes `this.load`, so can remove the `satisfies` check - 2.14.0 includes `this.meta.watchMode`, so can remove the env check - remove deprecated `rollupCommonJSResolveHack` - it hasn't done anything since 6fb0e75 in late 2020 (~2.5 years ago) - and has been formally deprecated since 74f6761 over a year ago - remove `objectHashIgnoreUnknownHack` warning - hasn't been needed for async functions since 9afc8df in early 2020 (~3.5 years ago) - so I think that's a long enough window to now remove the warning - also add a link in the docs to `object-hash` - noticed there wasn't one, despite all the links I added to the docs!
agilgur5
force-pushed
the
deps-upgrade-rollup
branch
from
86d987d
to
d8301eb
Compare
|
ooo tests caught that devDeps need updating too! awesome to see integration tests reaping rewards 🙂 |
|
Proactively bumped the repro template to use Rollup v3 (and TS v5 and rpt2 v0.35) |
|
Last time I tried to just update everything updatable, I got a lot of grief from tsjest |
Summary
Bumping the Rollup peerDep and removing legacy tech debt workarounds
module: 'ES2022'#435 (comment)Details
Rollup upgrade
3.7.5includes feat: simplifystackinfo in cli error rollup/rollup#4749buildEndworkaround from fix(diagnostics): workaround Rollup duplicating error messages #3732.60.0includesthis.load, so can remove thesatisfiescheck2.14.0includesthis.meta.watchMode, so can remove the env checkOther tech debt removals
Figured I'd remove some other deprecated code / tech debt while I'm at it
rollupCommonJSResolveHackrollupCommonJSResolveHack#367 over a year agoobjectHashIgnoreUnknownHackwarningobject-hash