EZP-30729: Added a possibility to exclude Content Types when running CleanupVersionsCommand

[kmadejski]

Question	Answer
JIRA issue	EZP-30729
Bug	yes
New feature	no
Target version	6.7/6.13/7.5/master
BC breaks	yes
Tests pass	yes
Doc needed	yes

This PR adds a possibility to exclude particular ContentTypes of which versions should not be removed. This option always includes content objects of default User ContentType (ID: 4, unfortunately, there is no const anywhere to use it instead of hardcoding it).

Moreover, I've added a ProgressBar which indicates the progress. In some cases, it takes some time to clean up a huge number of versions so the user might have a wrong impression that nothing is going on.

A second PR, introducing the usage of $status in ContentService::loadVersions method (introduced in: #2652) will be done soon, against 7.5 only.

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[alongosz]

Issues:

1. I don't really follow the change of how verbosity behaves from the default way (see the diff comments), for me it would be rather unexpected.
2. I'm having trouble running it with the default value of --keep. AFAICS neither options.default_version_archive_limit nor default_version_archive_limit is mapped to dynamic settings configuration. It's just a repository option (there's RepositoryConfigurationProvider AFAIR for that). But maybe I'm missing something? I tried to run it w/o any parameters and got:

[eZ\Publish\Core\MVC\Exception\ParameterNotFoundException]                               
  Parameter 'options.default_version_archive_limit' with namespace '' could not be found.

3. I see an issue with processing the new parameter (see the diff comments).

[andrerom]

In ContentService->internalPublishVersion() we have for quite some time been deleting overflow versions on publish. So it would be good if we could come to the bottom of why they have this issue, as this only workarounds part of the features which deals with deleting versions.

That said, including and excluding content types seems like a very good improvement on the command regardlessly. So comment above is only about setting user as default as opposed to better understanding what goes wrong on version deletion of users (users have extra tables, maybe that is part of the issue here, ...).

[alongosz]

I still have a question about:

2. I'm having trouble running it with the default value of --keep. AFAICS neither options.default_version_archive_limit nor default_version_archive_limit is mapped to dynamic settings configuration. It's just a repository option (there's RepositoryConfigurationProvider AFAIR for that). But maybe I'm missing something? I tried to run it w/o any parameters and got:

[eZ\Publish\Core\MVC\Exception\ParameterNotFoundException]                               
  Parameter 'options.default_version_archive_limit' with namespace '' could not be found.

Is it just me? :)

[kmadejski]

I still have a question about...

Unfortunately, not only you. I'm looking into that 😉

[kmadejski]

@alongosz issue no 2, @adamwojs removed usage of CT IDs and introduced the usage of identifiers, both done in 359251b

[micszo]

QA Approved on eZ Platform v1.7.9.
Testing other versions will be possible after merge / second PR is rebased.

[alongosz]

@kmadejski could you merge up?

[kmadejski]

Merged up in: e4ce240 / 5b6db1c / df5ff8d.