Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-538: Added Ibexa namespaces for future compatibility #3111

Merged
merged 4 commits into from
Jul 21, 2021
Merged

IBX-538: Added Ibexa namespaces for future compatibility #3111

merged 4 commits into from
Jul 21, 2021

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Jul 15, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-538
Bug/Improvement improvement
New feature no
Target version 7.5
BC breaks no
Tests pass I'm confident in my code
Doc needed no, internal

Adds namespaces that will be used in Ibexa DXP 4.0, since we're supposed to use them when creating new classes for 2.5 and up.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@Steveb-p Steveb-p requested a review from alongosz July 15, 2021 11:52
@Steveb-p Steveb-p mentioned this pull request Jul 15, 2021
Merged
6 tasks
@Steveb-p Steveb-p changed the title Added Ibexa namespaces for future compatibility IBX-538: Added Ibexa namespaces for future compatibility Jul 15, 2021
@Steveb-p Steveb-p requested a review from a team July 15, 2021 11:59
@alongosz alongosz requested review from adamwojs, Nattfarinn, ViniTou, webhdx and a team July 15, 2021 15:38
Nattfarinn
Nattfarinn suggested changes Jul 16, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@Steveb-p Steveb-p marked this pull request as draft July 16, 2021 20:45
@Steveb-p Steveb-p marked this pull request as ready for review July 19, 2021 08:36
@Steveb-p Steveb-p self-assigned this Jul 19, 2021
alongosz
alongosz approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. I see I need to fix some namespaces in ezplatform-kernel.json

@Steveb-p Steveb-p marked this pull request as draft July 20, 2021 08:30
@Steveb-p Steveb-p marked this pull request as ready for review July 20, 2021 09:17
@alongosz alongosz mentioned this pull request Jul 21, 2021
Merged
5 tasks
@alongosz
Copy link
Member

Checked composer validity, no further QA required. Merging.

@alongosz alongosz merged commit abd3b8a into 7.5 Jul 21, 2021
@alongosz alongosz deleted the add-ibexa-namespaces branch July 21, 2021 12:27
@alongosz
Copy link
Member

@Steveb-p you can merge it up

@Steveb-p Steveb-p mentioned this pull request Jul 21, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@adamwojs adamwojs adamwojs approved these changes

@webhdx webhdx Awaiting requested review from webhdx

@damianz5 damianz5 Awaiting requested review from damianz5

Assignees

@Steveb-p Steveb-p

Labels
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Steveb-p @alongosz @adamwojs @damianz5 @Nattfarinn @ViniTou