Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31560: Fixed ContentDeleteEvaluatorTest class file path #3113

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

alongosz
Copy link
Member

Question Answer
JIRA issue EZP-31560
Type bug
Target Ibexa version v2.5+
BC breaks no

Class eZ\Publish\Core\Limitation\Tests\LanguageLimitation\ContentDeleteEvaluatorTest was located in ./eZ/Publish/Core/Limitation/Tests/LangugeLimitation/ContentDeleteEvaluatorTest.php, which does not comply with neither psr-0 nor psr-4 autoloading standard (there's a typo in "LangugeLimitation" directory name).

Steps to reproduce:

Prerequisites: composer 2.0

Execute composer install --optmize-autoloader and observe the following warning:

Class eZ\Publish\Core\Limitation\Tests\LanguageLimitation\ContentDeleteEvaluatorTest located in ./eZ/Publish/Core/Limitation/Tests/LangugeLimitation/ContentDeleteEvaluatorTest.php does not comply with psr-0 autoloading standard. Skipping.

Despite #3111, keeping the old path for now, because rebranded sources have not been committed yet and for consistency's sake it would require to rebrand the whole Limitation tests subdirectory. Will be done as part of the actual rebranding.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage. // n/a
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

Class eZ\Publish\Core\Limitation\Tests\LanguageLimitation\ContentDeleteEvaluatorTest was located in ./eZ/Publish/Core/Limitation/Tests/LangugeLimitation/ContentDeleteEvaluatorTest.php, which does not comply with neither psr-0 nor psr-4 autoloading standard (a typo in LangugeLimitation directory name)
@alongosz alongosz merged commit 89294f4 into 7.5 Jul 22, 2021
@alongosz alongosz deleted the ezp-31560-fix-content-delete-evaluator-test-class branch July 22, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants