Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Get CI running consistently #42

Merged
merged 4 commits into from
Aug 17, 2022
Merged

ci: Get CI running consistently #42

merged 4 commits into from
Aug 17, 2022

Conversation

fabern
Copy link
Owner

@fabern fabern commented Jul 29, 2022

ci: Add macOS and Julia 1.7, remove Julia 1.6

As we still have discrepancies between local and CI testing check if it
is related to the architecture and Julia versions.

Nightly version on ubuntu is passing. Local testing happens on macOS and
Julia 1.7.2

As we still have discrepancies between local and CI testing check if it
is related to the architecture and Julia versions.

Nightly version on ubuntu is passing. Local testing happens on macOS and
Julia 1.7.2
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #42 (54a8850) into develop (0898c4c) will increase coverage by 0.42%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
+ Coverage    71.29%   71.71%   +0.42%     
===========================================
  Files           16       16              
  Lines         2139     2139              
===========================================
+ Hits          1525     1534       +9     
+ Misses         614      605       -9     
Impacted Files Coverage Δ
src/func_MSB_functions.jl 51.47% <0.00%> (+0.36%) ⬆️
src/func_DiffEq_definition_p.jl 91.30% <0.00%> (+0.86%) ⬆️
src/module_KPT.jl 61.58% <0.00%> (+1.69%) ⬆️
src/module_WAT.jl 67.80% <0.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0898c4c...54a8850. Read the comment docs.

@fabern fabern merged commit d586119 into develop Aug 17, 2022
@fabern
Copy link
Owner Author

fabern commented Aug 17, 2022

This was merged, although commit f427f69 needed to be reverted. There still seems to be an issue with floating point accuracy of the regression tests which gives reproducible tests on a local development machine. However, for the regression test to pass on the CI it seems that we'd need to hardcode a solution stemming from the CI to compare the current solution.

Options to solve:

  • define reference solution for regression tests on the CI
  • find out why the floating point accuracy is not given (linked to RNG seed?)
  • increase tolerance when comparing two solutions for regression tests. (Note: that this is somewhat against the purpose of the regression test.)

@fabern fabern deleted the limit-CI-runs branch April 6, 2023 20:14
@fabern
Copy link
Owner Author

fabern commented Apr 6, 2023

As of v0.9.5 (merging of PR #51) we are now also successfully testing the regression tests on the CI system.

This issue is resolved.

@fabern fabern mentioned this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants