ensure absolute path after strip to maintain rfc complaince #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanejohnson This should resolve your issue. |
aaronhurt
force-pushed
the
ensure-abs-path-after-strip
branch
from
93fd858 to
cb89bf9
Compare
pschultz
reviewed
Apr 23, 2019
There was a problem hiding this comment.
RFC2616 has been superseeded by 7230-7235 and the comment should reference https://tools.ietf.org/html/rfc7230#section-5.3.
Otherwise looks good to me.
|
Got it, I'll update the comment. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to inadvertently remove the leading slash from the request path when stripping which results in sending a malformed GET with a relative path to the backend server.
Example below ...
Origin URL:
Route:
Results in sending
GET oranges/steve.htmlto the 1.2.3.4 backend. Proper GET request should always be an absolute path or absolute URI according to the RFC (https://tools.ietf.org/html/rfc2616#section-5.1.2).