Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure absolute path after strip to maintain rfc complaince #645

Merged
merged 2 commits into from
Apr 23, 2019
Merged

ensure absolute path after strip to maintain rfc complaince #645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb89bf9
ensure absolute path after strip to maintain rfc complaince
Apr 18, 2019
01cee97
update comment to reflect current RFC
aaronhurt Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions proxy/http_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ func (p *HTTPProxy) ServeHTTP(w http.ResponseWriter, r *http.Request) {
// TODO(fs): a defensive approach.
if t.StripPath != "" && strings.HasPrefix(r.URL.Path, t.StripPath) {
targetURL.Path = targetURL.Path[len(t.StripPath):]
// ensure absolute path after stripping to maintain compliance with
// section 5.3 of RFC7230 (https://tools.ietf.org/html/rfc7230#section-5.3)
if !strings.HasPrefix(targetURL.Path, "/") {
targetURL.Path = "/" + targetURL.Path
}
}

if err := addHeaders(r, p.Config, t.StripPath); err != nil {
Expand Down