Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resyncPeriod=0 should imply no resync #2651

Closed
acmlearn opened this issue Dec 8, 2020 · 0 comments · Fixed by #2660
Closed

resyncPeriod=0 should imply no resync #2651

acmlearn opened this issue Dec 8, 2020 · 0 comments · Fixed by #2660
Assignees
@rohanKanojia
Labels
bug

Comments

@acmlearn
Copy link

acmlearn commented Dec 8, 2020 •
edited by manusa
Loading

Tried to test SharedInformerFactory examples using the blog https://rohaan.medium.com/introduction-to-fabric8-kubernetes-java-client-informer-api-b945082d69af.

When testing with 0 resync period, it is still relisting the updates within seconds.

sharedInformerFactory.sharedIndexInformerFor(
 Pod.class, // POJO for Pod resource
 PodList.class, // POJO for Pod list resource
 0 * 1000L); // resync period

As per definition for ResyncPeriod: if non-zero, will re-list this often (you will get OnUpdate calls, even if nothing changed). Otherwise, re-list will be delayed as long as possible (until the upstream source closes the watch or times out, or you stop the controller).
@acmlearn acmlearn mentioned this issue Dec 8, 2020
Closed
@rohanKanojia rohanKanojia self-assigned this Dec 10, 2020
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 11, 2020
@rohanKanojia
Fix fabric8io#2651: SharedInformers should ignore resync on zero resy…
6f3d9ec 
…ncPeriod

Refactor Reflector to ignore resync if resyncPeriod is set to zero
@rohanKanojia rohanKanojia mentioned this issue Dec 11, 2020
Merged
11 tasks
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 14, 2020
@rohanKanojia
Fix fabric8io#2651: SharedInformers should ignore resync on zero resy…
95b93c3 
…ncPeriod

Refactor Reflector to ignore resync if resyncPeriod is set to zero
@rohanKanojia rohanKanojia mentioned this issue Dec 16, 2020
Closed
@wangyang0918 wangyang0918 mentioned this issue May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2651: SharedInformers should ignore resync on zero resyncPeriod rohanKanojia/kubernetes-client
2 participants
@rohanKanojia @acmlearn