Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2651: SharedInformers should ignore resync on zero resyncPeriod #2660

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

rohanKanojia
Copy link
Member

Fix #2651

Refactor Reflector to ignore resync if resyncPeriod is set to zero

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

82.1% 82.1% Coverage
0.0% 0.0% Duplication

@rohanKanojia rohanKanojia self-assigned this Dec 14, 2020
@manusa
Copy link
Member

manusa commented Dec 15, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 1d1b39e into fabric8io:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resyncPeriod=0 should imply no resync
3 participants