Merge pull request #1043 from fabulous-dev/sync-view-fn-ui-thread

Ensure view function is only called on UI thread
fabulous-dev · Jun 1, 2023 · b3c9894 · b3c9894
2 parents 149c06e + 272a80c
commit b3c9894
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,7 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-_No unreleased changes_
+### Changed
+- `view` function now runs only on the UI thread by @TimLariviere (https://github.com/fabulous-dev/Fabulous/pull/1043)
 
 ## [2.3.1] - 2023-05-22
 

diff --git a/src/Fabulous/Runners.fs b/src/Fabulous/Runners.fs
@@ -206,16 +206,16 @@ module ViewAdapters =
         member _.OnStateChanged(args) =
             try
                 if args.Key = stateKey then
-                    let state = unbox args.NewState
+                    syncAction(fun () ->
+                        try
+                            let state = unbox args.NewState
 
-                    let prevWidget = _widget
-                    let currentWidget = (view state).Compile()
-                    _widget <- currentWidget
+                            let prevWidget = _widget
+                            let currentWidget = (view state).Compile()
+                            _widget <- currentWidget
 
-                    let node = getViewNode _root
+                            let node = getViewNode _root
 
-                    syncAction(fun () ->
-                        try
                             Reconciler.update canReuseView (ValueSome prevWidget) currentWidget node
                         with ex ->
                             if not(exceptionHandler ex) then