Ensure view function is only called on UI thread #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For performance reasons, we have decided to let
init,updateandviewrun on whatever thread the message was dispatched from. This is because the MVU functions don't access the UI itself, Fabulous deals with it exclusively during reconcilation so we only synchronize back to the UI thread during diffing to avoid the perf hit of jumping threads.But if we need to access some information related to the UI inside the
viewfunction (such as the safe area margins), it requires access to the UI thread, otherwise it could crash.This PR ensures that the view function is called only on the UI thread to avoid those issues.