-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to the new method of setting outputs #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 100% not sure if this script will have access to the env var $GITHUB_OUTPUT
. I'm assuming it's been exported and passed down through the subshells, but I
@@ -84,7 +84,7 @@ if ! gem push --key="$KEY" --host "$GEM_HOST" "$GEM_FILE" >push.out; then | |||
exit $gemerr | |||
fi | |||
|
|||
echo "::set-output name=pushed-version::$( parse-gemspec --version )" | |||
echo "pushed-version=$(parse-gemspec --version)" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 100% not sure if this script will have access to the env var $GITHUB_OUTPUT
. I'm assuming it's been exported at the workflow level and therefore passed down through the subshells, but worth testing before rolling this out and bumping versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does have access to it. But also: this is still calling it like "[...] $( parse-gemspec ) [...]"
, so if it was working before, it will keep working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composite actions do have access, but you're defo right that it should be tested
Part of fac/dev-platform#1271
Before:
After:
Also now supports multiple outputs at once: