Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the new method of setting outputs #16

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Switch to the new method of setting outputs #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fb85b2
Switch to the new method of setting outputs
DuncSmith Oct 17, 2022
6abab19
update superlinter
DuncSmith Oct 17, 2022
e0e12e6
bump actionlinter
DuncSmith Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ jobs:
linter:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
ref: ${{ github.head_ref }}
fetch-depth: 0 # Full history to get a proper list of changed files within `super-linter`

- name: Lint Code Base
uses: github/super-linter@v3
uses: github/super-linter@v4
env:
VALIDATE_ALL_CODEBASE: false
VALIDATE_BASH: true
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,19 @@ jobs:
name: runner / actionlint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: actionlint
uses: reviewdog/action-actionlint@v1.2.0
uses: reviewdog/action-actionlint@v1.33.0
with:
fail_on_error: true
reporter: github-pr-review
shellcheck:
name: runner / shellcheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: shellcheck
uses: reviewdog/action-shellcheck@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion gem-push-action.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ if ! gem push --key="$KEY" --host "$GEM_HOST" "$GEM_FILE" >push.out; then
exit $gemerr
fi

echo "::set-output name=pushed-version::$( parse-gemspec --version )"
echo "pushed-version=$(parse-gemspec --version)" >> "$GITHUB_OUTPUT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 100% not sure if this script will have access to the env var $GITHUB_OUTPUT. I'm assuming it's been exported at the workflow level and therefore passed down through the subshells, but worth testing before rolling this out and bumping versions.

Copy link
Member

@dgholz dgholz Oct 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does have access to it. But also: this is still calling it like "[...] $( parse-gemspec ) [...]", so if it was working before, it will keep working

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composite actions do have access, but you're defo right that it should be tested


if [[ $TAG_RELEASE == true ]]; then
tagname="v$( parse-gemspec --version )"
Expand Down