Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fby3.5: hd: Add ISR #488

Closed
wants to merge 1 commit into from
Closed

Conversation

Yi-Shum
Copy link
Collaborator

@Yi-Shum Yi-Shum commented Aug 15, 2022

Summary:

  • Remove HSC OCP setting and use default setting(600W).
    Because 320W CPU is used currently, if we set HSC OCP to 350W it will trigger HSC CSOUT during power on.
  • Add ISR to record the following SEL to BMC.
sensor type sensor number event data condition
C3h 56h(POWER_ERROR) 01FFFFh(SYS_PWROK_FAIL) asserted when PWRGD_CPU_LVC3 is low and FM_CPU_BIC_SLP_S3_N is high.
C9h 10h(SYSTEM_STATUS) 00FFFFh(SYS_THERMAL_TRIP) asserted when FM_CPU_BIC_THERMTRIP_N falls
C9h 10h(SYSTEM_STATUS) 02FFFFh(SYS_THROTTLE) asserted/deassert when FM_CPU_BIC_PROCHOT_LVT3_N falls/rises
C9h 10h(SYSTEM_STATUS) 05FFFFh(SYS_PMBUSALERT) asserted/deassert when IRQ_HSC_ALERT1_N falls/rises
C9h 10h(SYSTEM_STATUS) 06FFFFh(SYS_HSCTIMER) asserted/deassert when FM_HSC_TIMER rises/falls
C9h 10h(SYSTEM_STATUS) 07FFFFh(SYS_FIRMWAREASSERT) asserted/deassert when FAST_PROCHOT_N falls/rises
C9h 10h(SYSTEM_STATUS) 0AFFFFh(SYS_VRWATCHDOG) asserted when PWRGD_CPU_LVC3 is low after FM_CPU_BIC_SLP_S3_N is high of 10 second.
CBh 71h(VR_OCP) byte 1: VR number
0 - PVDDCR_CPU0
1 - PVDDCR_CPU1
2 - PVDD11_S3
byte 2: FFh
byte 3: FFh
asserted/deassert when PVDDCR_CPU0_BIC_OCP_N, PVDDCR_CPU1_BIC_OCP_N, PVDD11_S3_BIC_OCP_N fall/rise
CBh 72h(VR_ALERT) byte 1: VR number and page
bit [7:1] - VR number
bit [0] - page
byte 2: VR STATUS_WORD byte 0
byte 3: VR STATUS_WORD byte 1
asserted/deassert when PVDDCR_CPU0_PMALERT_N, PVDDCR_CPU1_PMALERT_N, PVDD11_S3_PMALERT_N fall/rise
CCh BDh(HDT_PRESENT) FFFFFFh asserted/deassert when FM_DBP_PRESENT_N falls/rises

Test Plan:
Build code: Pass

Summary:
- Remove HSC OCP setting and use default setting(600W).
  Because 320W CPU is used currently, if we set HSC OCP to 350W it will triger HSC CSOUT during power on.
- Add function to record the following SEL to BMC.
sensor type	, sensor number		, event data			, condition
C3h		, 56h(POWER_ERROR)	, 01FFFFh(SYS_PWROK_FAIL)	, asserted when PWRGD_CPU_LVC3 is low and FM_CPU_BIC_SLP_S3_N is high.
C9h		, 10h(SYSTEM_STATUS)	, 00FFFFh(SYS_THERMAL_TRIP)	, asserted when FM_CPU_BIC_THERMTRIP_N falls
C9h		, 10h(SYSTEM_STATUS)	, 02FFFFh(SYS_THROTTLE)		, asserted/deassert when FM_CPU_BIC_PROCHOT_LVT3_N falls/rises
C9h		, 10h(SYSTEM_STATUS)	, 05FFFFh(SYS_PMBUSALERT)	, asserted/deassert when IRQ_HSC_ALERT1_N falls/rises
C9h		, 10h(SYSTEM_STATUS)	, 06FFFFh(SYS_HSCTIMER)		, asserted/deassert when FM_HSC_TIMER rises/falls
C9h		, 10h(SYSTEM_STATUS)	, 07FFFFh(SYS_FIRMWAREASSERT)	, asserted/deassert when FAST_PROCHOT_N falls/rises
C9h		, 10h(SYSTEM_STATUS)	, 0AFFFFh(SYS_VRWATCHDOG)	, asserted when PWRGD_CPU_LVC3 is low after FM_CPU_BIC_SLP_S3_N is high of 10 second.
CBh		, 71h(VR_OCP)		, byte 1: VR number		, asserted/deassert when PVDDCR_CPU0_BIC_OCP_N, PVDDCR_CPU1_BIC_OCP_N, PVDD11_S3_BIC_OCP_N fall/rise
						     0 - PVDDCR_CPU0
						     1 - PVDDCR_CPU1
						     2 - PVDD11_S3
					  byte 2: FFh
					  byte 3: FFh

CBh		, 72h(VR_ALERT)		, byte 1: VR number and page	, asserted/deassert when PVDDCR_CPU0_PMALERT_N, PVDDCR_CPU1_PMALERT_N, PVDD11_S3_PMALERT_N fall/rise
					  	bit [7:1] - VR number
					  	bit [0] - page
					  byte 2: VR STATUS_WORD byte 0
					  byte 3: VR STATUS_WORD byte 1

CCh		, BDh(HDT_PRESENT)	, FFFFFFh			, asserted/deassert when FM_DBP_PRESENT_N falls/rises

Test Plan:
Build code: Pass
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 15, 2022
@facebook-github-bot
Copy link
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants