Webpack loaders don't support .bmp - with PR

[bebbi]

If you are reporting a bug, please fill in below. Otherwise feel free to remove this template entirely.

Can you reproduce the problem with latest npm?

yes, 3.10.9
If you're using OS X or Linux, run this to update npm:

Description

Can't import .bmp files without the PUBLIC_FOLDER workaround

Expected behavior

Compilation succeeded :-)

Actual behavior

Failed to compile.

Error in ./src/sonic.bmp
Module parse failed: /Users/me/fabric/src/sonic.bmp Unexpected character '�' (1:3)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected character '�' (1:3)
@ ./src/MyStuff.js 16:13-35

I'll prepare a PR to add bmp to the webpack module loaders in prod and dev.

[gaearon]

BMP is not a web image format. It's extremely heavy.
We should not be encouraging people to use it on the web.

Since there is a workaround (public folder) I would like to close this.
Sorry!

[bebbi]

This is solved via #667. Agree but still happy because the use-case requires 50 x 1.5k original bmps that I can now consider source of truth as-is and inline :)

On 20 Nov 2016, at 19:57, Dan Abramov notifications@github.com wrote:

BMP is not a web image format. It's extremely heavy.
We should not be encouraging people to use it on the web.

Since there is a workaround (public folder) I would like to close this.
Sorry!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #1033 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ACn_h9Zd8oq5mxm-TcZg59hDeKrXmzURks5rAJgNgaJpZM4KvDTG.

[gaearon]

Fair enough :-)