Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .bmp format images to webpack loader. Fixes #1033. #1034

Closed
wants to merge 1 commit into from

Conversation

bebbi
Copy link
Contributor

@bebbi bebbi commented Nov 10, 2016

cf #1033

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fson
Copy link
Contributor

fson commented Nov 17, 2016

We want to fix issues like this once and for all by adding a catch-all for all unknown extensions as described in #667. Nobody seems to have claimed it yet, @bebbi would you be interested in working on it?

Until that gets added, using the public folder is a good workaround, so I think we're not taking this PR, but I'm happy to review a PR that implements #667.

@fson fson closed this Nov 17, 2016
@bebbi bebbi deleted the fix-load-bmp branch November 21, 2016 07:29
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants