-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Dart Sass #5282
Comments
If you uninstall We support whatever sass-loader supports. Can you try this please? edit: nevermind it looks like we might need to explicitly specify |
I'm actually the lead dev of Sass, not a React user, so I don't have a setup handy to try this on. |
No worries! Thanks for the heads up, then. We'll get to this sometime soon. 😄 Thanks! |
Was able to get dart-sass working by adding this to package.json and using yarn resolutions (https://yarnpkg.com/lang/en/docs/selective-version-resolutions/), if anyone wants to test it out. "resolutions": { |
If you're not using yarn, npm 6.9 added package-aliasing, so Run Further reading: |
Adding
to |
As yarn workspaces don’t allow the use of resolutions this means I am limited to node sass and that, via node gyp and tar has a security violation, plus as the originator for this ticket says, the dart implementation is now the reference |
You can add it to resolution field in yarn workspaces. Once sass-loader releases a new version we will support sass out of the box. |
sass-loader has released a new version v7.2.0 today, so when will create-react-app follows up? |
It's not on npm yet https://www.npmjs.com/package/sass-loader |
It looks like version 2.0.0 added support for Sass, which is rad! However, it also looks like it only supports Node Sass, which uses LibSass. It would be good to support Dart Sass, the new reference implementation that's distributed as pure JS, as well. This means that it doesn't require users to either download a binary blog or natively compile C++ code to use. See the
sass-loader
documentation for how to configure it to use Dart Sass.The text was updated successfully, but these errors were encountered: