Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Audit #103

Merged
merged 13 commits into from
Mar 17, 2019
Merged

CSS Audit #103

merged 13 commits into from
Mar 17, 2019

Conversation

talldan
Copy link
Collaborator

@talldan talldan commented Mar 16, 2019

Closes #80

  • Adds stylelintrc - the one from Gutenberg
  • Adds sass package (as an alias to node-sass)
  • Remove unused styles (in app/style.css)
  • Switch to BEM style naming convention block__element--modifier and take advantage of sass interpolation.
  • Move styles from app to pages (header, title, etc.)
  • Move styles from tabs to preferences (input, directory-select, etc.)

@talldan talldan self-assigned this Mar 16, 2019
@talldan talldan added the [Type] Bug Something isn't working label Mar 17, 2019
@talldan
Copy link
Collaborator Author

talldan commented Mar 17, 2019

Ready for review.

@pento
Copy link
Owner

pento commented Mar 17, 2019

NPM 6.9 allows us to alias sass to node-sass, by installing it as npm install node-sass@npm:sass (ref).

@talldan
Copy link
Collaborator Author

talldan commented Mar 17, 2019

@pento 👍 switched to sass as recommended.

Copy link
Owner

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's get this in, so we can rebase all of the PRs waiting for it. 🙂

@talldan talldan merged commit 721d29d into master Mar 17, 2019
@talldan talldan deleted the update/css-audit branch March 17, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants