-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dart-sass support default #626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? You need accept CLA and fix tests
@evilebottnawi fixed. |
@xiaoxiangmoe Why we should switch on |
This code will use node-sass as the default implementation. Dart-sass is used when node-sass is missing and dart sass is installed. So there are no destructive updates. https://sass-lang.com/dart-sass
|
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
==========================================
- Coverage 97.79% 97.24% -0.56%
==========================================
Files 6 6
Lines 136 145 +9
==========================================
+ Hits 133 141 +8
- Misses 3 4 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but it is breaking change, wen can merge this only for major
release
It isn't breaking change. It will still use node-sass if there exists node-sass without configuring the implementation. This only affects users who have installed dart-sass without installing node-sass and without configuring the implementation. If we want to switch to use dart-sass default. It is break change. Maybe we can checkout to it in next major release. |
@xiaoxiangmoe it is breaking change for people who don't install |
Okay. @evilebottnawi Could you please tell me the plan for the release of the next major version? Thanks. |
fir problem #556 (comment) and |
If that is going in a next major version then there is no need for fallback. We can just reverse whatever we do now.. from
to
rite? It will be breaking however @xiaoxiangmoe @evilebottnawi |
@sibiraj-s what do you mean? |
Hi @evilebottnawi . Here for new installations You said that this PR will go in the next major release(considering We can just reverse the existing method. Instead of looking for |
/cc @jhnns |
/cc @xiaoxiangmoe need investigate why coverage decrease |
WIP on this, will be released in |
Close in favor #646, will be released in |
@evilebottnawi When will |
@xiaoxiangmoe when it is ready for release, already in my todo list, ETA is around 1-2 weeks |
@xiaoxiangmoe many work, this month, sorry |
@evilebottnawi Excuse me. Do you need any help? |
@xiaoxiangmoe migrate test on jest and snapshoting |
No description provided.