Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails by default when running tests in travis #532

Closed
ForbesLindesay opened this issue Sep 1, 2016 · 1 comment
Closed

Fails by default when running tests in travis #532

ForbesLindesay opened this issue Sep 1, 2016 · 1 comment
Milestone
0.3.0

Comments

@ForbesLindesay
Copy link
Contributor

Because we enable watch by default, tests will fail if you enable any CI server.

We can fix this in the majority of popular CI systems by checking for process.env.CI='true' (see https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables), and then disabling --watch.
@gaearon
Copy link
Contributor

gaearon commented Sep 1, 2016

Sounds good, would you like to make a PR? I was planning to suggest that people who need this create test-ci that is just react-scripts test but this seems even better. Maybe we can even kill explicit --watch in the config completely then and just respect CI env?

@gaearon gaearon added this to the 0.3.0 milestone Sep 1, 2016
@gaearon gaearon mentioned this issue Sep 1, 2016
Merged
gaearon added a commit that referenced this issue Sep 1, 2016
@gaearon
Enable watch implicitly unless on CI
01e5714 
Fixes #532
gaearon added a commit that referenced this issue Sep 1, 2016
@gaearon
Enable watch implicitly unless on CI (#533)
a52b697 
Fixes #532
stayradiated pushed a commit to stayradiated/create-react-app that referenced this issue Sep 7, 2016
@gaearon
Enable watch implicitly unless on CI (facebook#533)
003b6ef 
Fixes facebook#532
feiqitian pushed a commit to feiqitian/create-react-app that referenced this issue Oct 25, 2016
@gaearon @feiqitian
Enable watch implicitly unless on CI (facebook#533)
f148a34 
Fixes facebook#532
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@gaearon @ForbesLindesay