Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable watch implicitly unless on CI #533

Merged
merged 1 commit into from
Sep 1, 2016
Merged

Enable watch implicitly unless on CI #533

merged 1 commit into from
Sep 1, 2016

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Sep 1, 2016

Fixes #532.

By default project won’t have --watch.
We will always assume that react-scripts test launches the watcher.

However we offer an escape hatch. If process.env.CI is defined, we disable watching. This should satisfy most use cases, and people who really insist on not using a watcher can always CI=true npm test. However our intention is to keep improving the watcher and we will push for it to become the default workflow.

@gaearon gaearon modified the milestones: 0.2.3, 0.3.0 Sep 1, 2016
@ghost ghost added the CLA Signed label Sep 1, 2016
@ghost ghost added the CLA Signed label Sep 1, 2016
@gaearon gaearon merged commit a52b697 into master Sep 1, 2016
@gaearon gaearon deleted the implicit-watch branch September 1, 2016 16:25
@gaearon gaearon mentioned this pull request Sep 1, 2016
stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant