Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of date eslint plugin causes Parsing error: Cannot read property 'map' of undefined #9583

Closed
radiosilence opened this issue Sep 2, 2020 · 4 comments · Fixed by #9434
Closed

Out of date eslint plugin causes Parsing error: Cannot read property 'map' of undefined #9583

radiosilence opened this issue Sep 2, 2020 · 4 comments · Fixed by #9434
Labels
issue: bug report needs triage

Comments

@radiosilence
Copy link

radiosilence commented Sep 2, 2020 •
edited
Loading

Describe the bug

I've upgraded my project's TypeScript to version 4. It seems this creates an issue because react-scripts @typescript-eslint/parser is out of date. Could we bump these packages?

Currently I am doing this in my package.json:

  "resolutions": {
    "**/@typescript-eslint/parser": "4.0.1",
    "**/@typescript-eslint/eslint-plugin": "4.0.1"
  },

as a workaround.
@radiosilence radiosilence changed the title Out of date eslint causes Parsing error: Cannot read property 'map' of undefined Out of date eslint plugin causes Parsing error: Cannot read property 'map' of undefined Sep 2, 2020
@thien-do
Copy link
Contributor

thien-do commented Sep 2, 2020 •
edited
Loading

The resolutions is for Yarn, for NPM uses https://docs.npmjs.com/cli/shrinkwrap or https://www.npmjs.com/package/npm-force-resolutions

Anyway look like CRA is using version 2 of the plugin.. that means 2 major versions of the plugin and 1 major version of eslint we're behind

@stewie1570 stewie1570 mentioned this issue Sep 3, 2020
Closed
3 tasks
@radiosilence
Copy link
Author

Yeah it is quite a way behind. What would be the negatives of bumping it?

@radiosilence
Copy link
Author

#9590 Submitted a PR. Wonder when all the builds will start working :S

@radiosilence radiosilence mentioned this issue Sep 3, 2020
Closed
@MichaelDeBoey MichaelDeBoey mentioned this issue Sep 4, 2020
Merged
JaninaWibker added a commit to JaninaWibker/spreadsheets that referenced this issue Sep 6, 2020
@JaninaWibker
migrated to typescript
38e5568 
WARNING: broken build atm because eslint-typescript is broken / out of date in create-react-app (facebook/create-react-app#9583)
@tcatkins99 tcatkins99 mentioned this issue Sep 9, 2020
Closed
2 tasks
@thien-do
Copy link
Contributor

I've just realized the PR is tagged with v4 :( is there any chance we can still have this in v3?

dtinth added a commit to dtinth/auden that referenced this issue Sep 25, 2020
@dtinth
https://github.com/facebook/create-react-app/issues/9583
7c419d5
@jamaljsr jamaljsr mentioned this issue Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug report needs triage
Projects
None yet
Milestone
No milestone
2 participants
@radiosilence @thien-do