Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript eslint plugins to v4 #9590

Closed
wants to merge 1 commit into from
Closed

Update typescript eslint plugins to v4 #9590

wants to merge 1 commit into from

Conversation

radiosilence
Copy link

@radiosilence radiosilence commented Sep 3, 2020

Should be backwards compatible, but adding support for TypeScript 4 in projects using CRA

Fixes #9583

Should be backwards compatible, but adding support for TypeScript 4 in projects using CRA
@facebook-github-bot
Copy link

Hi @radiosilence!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stephen-risk-first
Copy link

I think these updates might need to made within the peer dependencies of the eslint-config-react-app package instead.

@MichaelDeBoey
Copy link
Contributor

This is going to be fixed by #9434

@petetnt
Copy link
Contributor

petetnt commented Sep 7, 2020

Closing as duplicate of #9434 , lets follow up there!

@petetnt petetnt closed this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of date eslint plugin causes Parsing error: Cannot read property 'map' of undefined
5 participants