Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default .editorconfig to template #11329

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ceithir
Copy link

@ceithir ceithir commented Aug 21, 2021

Same file as https://github.com/facebook/react
So just expliciting the de facto default coding standard used

I noticed I kept adding that file myself manually to all my new CRA projects, so I was wondering if maybe it should be part of the default template? .editorconfig files are quite standard nowadays, and it feels appropriate to generate them similarly to the .gitignore file.

Pull request is sadly blind as I've been unable to run the test on my local machine (known issue: #9811).

Same file as https://github.com/facebook/react
So just expliciting the _de facto_ default coding standard used
@facebook-github-bot
Copy link

Hi @ceithir!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ninezero90hy
Copy link

I think it's reasonable to add the setting file.
@ceithir Please resolve the conflict. 😉
I want PR merge.

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants